[ptx] hugin, auto selection of optimization values

Bruno Postle bruno at postle.net
Fri Jan 7 09:36:21 GMT 2005


This is a bug that appeared a few months ago, previously hugin did 
the right thing, I'll try and describe it.

It's easier to see if you load a single image, though the problem is 
the same with multiple images.

Select a pair of vertical or horizontal control points, and 
optimisation for 'roll' is automatically selected, OK.

Select two pairs of vertical control points and optimisation for 
both 'roll' and 'pitch' is automatically selected, OK.

Select two pairs of horizontal control points and optimisation for 
'roll' and 'pitch' is automatically selected.

I can't think of any circumstances where horizontal control points 
could control 'pitch' in any useful way, whereas they would control 
'yaw' when using rectilinear output.

Just to prove I'm not completely useless, here is a patch that fixes 
this behaviour.

-- 
Bruno
-------------- next part --------------
Index: src/hugin/OptimizePanel.cpp
===================================================================
RCS file: /cvsroot/hugin/hugin/src/hugin/OptimizePanel.cpp,v
retrieving revision 1.17
diff -r1.17 OptimizePanel.cpp
530,531c530
<         // remove yaw for reference image
<         m_yaw_list->Check(refImg,false);
---
>         // TODO this really should only set yaw for rectilinear
534a534,540
>         }
>         if (nHCP == 0) {
>             m_yaw_list->Check(refImg,false);
>         } else if (nHCP == 1) {
>             m_yaw_list->Check(refImg,false);
>         }
>         if (nVCP == 0) {
536c542
<         } else if (n == 1) {
---
>         } else if (nVCP == 1) {


More information about the ptX mailing list