[Bins] Re: should not *require* each child element in an XML file

Jérôme Sautret zubrow at gmail.com
Tue Nov 29 23:06:32 GMT 2005


2005/11/4, Martin Michlmayr <tbm at cyrius.com>:
> tags 308338 + patch pending
> thanks
>
> * Martin Michlmayr <tbm at cyrius.com> [2005-05-09 16:33]:
> > The documentation says that you can create a image.jpg.xml with three
> > child elements and something similar applies to album.xml.  I don't
> > have to specify anything in <bins> and <exif>, I only want to fill in
> > <description>.  However, BINS fails if you don't add these elements,
> > even if they are just empty.  It would be nice if the program would
> > not require that each of these elements are there.
>
> Here's a patch for this.  It makes the whole XML handling a bit nicer:
> it actually checks whether the XML files appear to be valid bins files
> (i.e., contain <image> or <album> elements) - at the moment, you just
> get a very cryptic error if this is not the case.  Additionally, all
> elements are not optional.

The consequence is that the exif information is not saved anymore in
the XML file if the exif tag is not present. I'll try to look at your
patch to correct that.


More information about the Bins mailing list