[Bins] Re: Bug#270396: bins_edit generates wrong encoding in .xml

[Martin Michlmayr]

* Ludovic Rousseau <ludovic.rousseau at free.fr> [2005-11-05 18:27]:
> > > > Can you provide a sample file so I can reproduce the bug here?
> > > To reproduce this bug please please execute this command in ru_RU.KOI8-R 
> > > locale:
> > 
> > Ludovic, do you have some time to look at this?
> 
> It was not easy to reproduce since I had to cut-n-paste a ru_RU.KOI8-R
> string.
> 
> I can reprodude the problem and the patch Alexander provided corrects it.
> I don't know if has some bad side effects.
> 
> Since bins_edit evolved a bit the patch should now be:
> 
> --- /usr/bin/bins_edit  2005-10-15 17:02:06.000000000 +0200
> +++ bins_edit   2005-11-05 18:19:32.000000000 +0100
> @@ -189,6 +189,7 @@
>      $value = encode_entities($value, '\00-\31<&"');
>    }
>  
> +  $value = $converter->convert($value);
>    my $characters =
>      XML::Grove::Characters->new( Data =>
>                                  decodeEntites($value));
> @@ -283,7 +284,7 @@
>    my $fileHandler = new IO::File;
>    open($fileHandler, '>', $file)
>      or die("Cannot open file $file to write Exif tag ($!)");
> -  binmode($fileHandler, ":utf8") if $^V ge v5.8.0;
> +  #binmode($fileHandler, ":utf8") if $^V ge v5.8.0;
>  
>    my $my_handler = new XML::Handler::YAWriter( 'Output' => $fileHandler,
>                                          #      'Escape' => {
> 
> 
> I suggest to ask Jérôme to include the patch upstream.

Jérôme, can you please take a look at the bug report at
http://bugs.debian.org/270396 and the patch suggested here.
-- 
Martin Michlmayr
http://www.cyrius.com/