[Bins] Language corrections in binsrc

Robert Funnell robert.funnell at mcgill.ca
Sat Sep 18 02:20:14 BST 2004


Haroon -

Thanks for making the changes and doing the diff, which I probably
should have done in the first place. Reviewing the diff, I found one
or two changes that you missed and one or two that I'd missed, plus
some improvements by you.

I've now done my own diff for binsrc which hopefully includes all the
changes. It is attached as bins-grammar-patch2.diff . (Your attachment
got through OK so I assume that mine will.)

Reading binsrc again, I noticed something odd in the sections on the
"hidden" and "ignore" parameters. The first section refers to
sub-album.xml but then refers to an album, while the second section
refers to album.xml but then refers to a sub-album. Is there an
inconsistency here?

Also, the section on the ignore parameter refers to the "ignore"
field, and the section on the hidden parameter also refers to the
"ignore" field. Should the section on the hidden parameter be
referring to a "hidden" field?

I'm not sure I understand what's going on here, so I haven't included
these changes in my diff.

- Robert

On Fri, 17 Sep 2004, Corporate Gadfly wrote:

>
> Very nice, Robert. Great attention to detail.
>
> >From: Robert Funnell <robert.funnell at mcgill.ca>
> >To: bins at email-lists.org
> >Subject: [Bins] Language corrections in binsrc
> >Date: Fri, 17 Sep 2004 11:50:51 -0400 (EDT)
> >
> >I've just started playing with BINS - it looks very nice.
> >I'd like to suggest the following corrections to the English in
> >binsrc:
>
> >
>
> I have taken the liberty of creating a diff with your suggestions. Here's
> the diff -u output (in the body of the email). I'll try and attach it as
> well (let's hope the mailing list allows it).
> ...
-------------- next part --------------
--- binsrc.orig	Fri Sep 17 10:08:23 2004
+++ binsrc	Fri Sep 17 21:01:18 2004
@@ -9,7 +9,7 @@
 albums. You can also put these parameters (when it makes sense) in the
 album (album.xml) or image (image_name.jpg.xml for example)
 description files, in the <bins> section of these files, to
-personalize only some album, sub-album or images pages.
+personalize only some album, sub-album or image pages.
 
 Note that you may have to "touch" the original image (or erase the
 destination one) in order to regenerate scaled or thumbnail pictures
@@ -28,7 +28,7 @@
     /
   </parameter>
 
-  <!-- Put here the mailaddress of the album-maintainer.  If this is
+  <!-- Put here the e-mail address of the album-maintainer.  If this is
   set, you will get a mail-icon in your views that links to this
   address. Only in joi templates for now. -->
   <parameter name="feedbackMail">
@@ -39,7 +39,7 @@
     blue
   </parameter>
 
-  <!-- If set to 1, preview-thumbnails will be showed in the
+  <!-- If set to 1, preview-thumbnails will be shown in the
   album-tree-page. This works only with joi templates for now. -->
   <parameter name="treePreview">
     1
@@ -110,22 +110,22 @@
 
   <!-- If set to 1, add empty description fields in the <description>
   section when the image description file is created to ease later
-  edition with an text editor -->
+  editing with a text editor -->
   <parameter name="createEmptyDescFields">
     1
   </parameter>
 
-  <!-- Put here a comma separated list of keywords. If one on this
-  keyword is found in the "ignore" field in the <description> section
-  of an sub-album.xml, then this album will be hidden, i.e. it
+  <!-- Put here a comma separated list of keywords. If one of these
+  keywords is found in the "ignore" field in the <description> section
+  of a sub-album.xml, then this album will be hidden, i.e. it
   will be generated but not linked anywhere. You can also use the -n
   command line option.  -->
   <parameter name="hidden">
     private
   </parameter>
 
-  <!-- Put here a comma separated list of keywords. If one on this
-  keyword is found in the "ignore" field in the <description> section
+  <!-- Put here a comma separated list of keywords. If one of these
+  keywords is found in the "ignore" field in the <description> section
   of an album.xml, then this sub-album will be ignored, i.e. it
   will not be processed. You can also use the -i command line option.
   -->
@@ -140,7 +140,7 @@
   </parameter>
 
   <!-- whether to convert generated jpegs to progressive using
-  jpegtran (if available).  can be never, always, or smaller (if the
+  jpegtran (if available).  Can be never, always, or smaller (if the
   progressified file is smaller than the baseline). --> 
   <parameter name="jpegProgressify">
     smaller
@@ -160,9 +160,9 @@
   </parameter>
 
    <!-- Size to use when user clicks directly on the thumbnail in the
-   thumbnails page instead of one of the size name. 0 is the first
+   thumbnails page instead of one of the size names. 0 is the first
    size (Small in the default config), 1 the second (Medium), and so
-   on. The different sizes are parametred in the <sizes> section
+   on. The different sizes are parameterized in the <sizes> section
    below. Set this value to -1 if you don't want the thumbnail to
    be clickable. -->
   <parameter name="defaultSize">
@@ -182,7 +182,7 @@
   
   <!-- If set to 1, generate a page with all thumbnails in the album
   and sub-albums. This is deactivated because it is an alpha feature
-  which seems to doesn't work properly. -->
+  which doesn't seem to work properly. -->
   <parameter name="allThumbnailsPage">
     0
   </parameter>
@@ -222,7 +222,7 @@
   </parameter>
   
   <!-- Do we rotate images if the Orientation Exif tag is found ? If
-  set to 'orginal', the orginal image is rotated the first time, and
+  set to 'original', the original image is rotated the first time, and
   then it is left untouched (unless the Orientation field in its desc
   file is modified manually). If set to 'destination', this is all the
   scaled images and thumnails that are rotated. This is less
@@ -232,7 +232,7 @@
     destination
   </parameter>
 
-  <!-- If set to 1, bins try to use the jpegtran program to rotate
+  <!-- If set to 1, bins tries to use the jpegtran program to rotate
   JPEG images if it is available. jpegtran is faster and lossless,
   but some versions fail to perform rotation correctly, so it is
   deactivated in default config. If set to 0 or if jpegtran is not
@@ -301,7 +301,7 @@
   </parameter>
 
    <!-- If set to 1, generated HTML code is cleaned up to reduce the
-   size of pages and thus, speed up browsing. This reduces the size of
+   size of pages and thus speed up browsing. This reduces the size of
    HTML BINS files by about 30%. See HTML::Clean(3) to know how
    optimizations are performed. -->
   <parameter name="compactHTML">
@@ -309,14 +309,14 @@
   </parameter>
 
    <!-- If set to 1, add some javascript code in image pages to
-   preload the next image of the same size when current one is loaded,
+   preload the next image of the same size when the current one is loaded,
    to speed up the album browsing. -->
   <parameter name="javaScriptPreloadImage">
     1
   </parameter>
 
    <!-- If set to 1, add some javascript code in thumbnails pages to
-   preload thumbnails of the next page when current one is loaded, to
+   preload thumbnails of the next page when the current one is loaded, to
    speed up the album browsing. -->
   <parameter name="javaScriptPreloadThumbs">
     1
@@ -334,13 +334,13 @@
     1
   </parameter>
 
-  <!--######################## Sizes parameters #########################-->
+  <!--######################## Size parameters ##########################-->
 
   <!-- you can change here the number of scaled images that will be
   generated for each image in the albums, as well as their names and
   sizes. The size can be a percentage of the original picture (a
-  number followed by % caracter, with no space) or a absolute size in
-  pixel. You can set any number of <size> tag (well, at least
+  number followed by % character, with no space) or an absolute size in
+  pixels. You can set any number of <size> tags (well, at least
   one...). -->
   <sizes>
     <size name="Small" shortname="Sm" height="40%" width="40%"/>
@@ -348,12 +348,12 @@
     <size name="Large" shortname="Lg" height="100%" width="100%"/>
   </sizes>
   
-  <!--####################### Colors parameters ########################-->
+  <!--####################### Color parameters #########################-->
 
   <!-- these are the colors to use for HTML generation. You can also
   use these tags in the <bins> section of album or image description
   files, even just some of the <color> tags (in this case, this will
-  just change the corresponding items color for that album/picture).
+  just change the corresponding item color for that album/picture).
   -->
   <colors style="blue">
     <color name="PAGE_BACK">


More information about the Bins mailing list