[Bins] PATCH: Quotes In Filenames, Crash on Buggy Images, accesskey fix

Cole, Phillip phillip.cole at uk.coltgroup.com
Fri Mar 26 18:47:53 GMT 2004


Thanks for creating BINS, it's wonderful.  I have used it to archive over
5GB of my companies product images. I am using the "joi" template.   I found
a couple of problems:

1) There was a divide by zero error that caused a crash, due to a corrupt
image, but it shouldn't cause a crash.  I added a divide by zero check.

2) When a singe quote was included in a filename, or directory name
javascript errors occured because the quote was not escaped.  I have created
a new function jssafe_uri_encode and switched all callers of uri_encode to
it.  I have also needed to add html_entities so that double quotes get
changed to " etc. This also meant a couple of minor tweaks had to be
made to the template files.

3) accesskey="t" is showing in the image view page.  This is a joi template
bug.

Here are my patches that fix these problems:

 <<bins-p1.diff>>  <<imagenavbar-p1.diff>>  <<tree.html-p1.diff>> 
Regards

Phil Cole


**************************************************************************************************
The contents of this email and any attachments are confidential.
It is intended for the named recipient(s) only.
If you have received this email in error please notify the system manager or  the 
sender immediately and do not disclose the contents to any one or make copies.

This transmission contains information which may be confidential and which may also 
be privileged.  It is intended for the named addressee only.  Unless you are the named 
addressee, or authorised to receive it for the addressee, you may not copy or use it or 
disclose it to anyone else.

This transmission is not a binding contract, all electronic mail messages are subject to 
contract and are not to be understood as a contract agreement. A binding contract 
will only be concluded once an agreed paper document has been physically signed.

Thank you for your co-operation

** eSafe scanned this email for viruses, vandals and malicious content **
**************************************************************************************************
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bins-p1.diff
Type: application/octet-stream
Size: 13670 bytes
Desc: not available
Url : http://www.email-lists.org/pipermail/bins/attachments/20040326/7653cfba/bins-p1.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: imagenavbar-p1.diff
Type: application/octet-stream
Size: 711 bytes
Desc: not available
Url : http://www.email-lists.org/pipermail/bins/attachments/20040326/7653cfba/imagenavbar-p1.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tree.html-p1.diff
Type: application/octet-stream
Size: 693 bytes
Desc: not available
Url : http://www.email-lists.org/pipermail/bins/attachments/20040326/7653cfba/tree.html-p1.obj


More information about the Bins mailing list